feat: Personal stats #18
Conversation
feat: Colored text for personal stats
fix: Proper display of stars for 2022 Day 25
aoc-client/src/lib.rs
Outdated
| } else if response.status() == StatusCode::FOUND { | ||
| // A 302 reponse is a redirect and it likely | ||
| // means we're not logged in | ||
| warn!( | ||
| "🍪 It looks like you are not logged in, try logging in again" | ||
| ); | ||
| return Err(AocError::AocResponseError); | ||
| } |
There was a problem hiding this comment.
Maybe this deserves a new error, say AocError::NotLoggedIn. When showing the calendar not being logged in isn't a problem as you can still show the calendar with no stars. But here it's different...
aoc-client/src/lib.rs
Outdated
| "--------Part 1---------", | ||
| &"--------Part 1---------".color(SILVER).to_string(), | ||
| ) | ||
| .replace( | ||
| "--------Part 2---------", | ||
| &"--------Part 2---------".color(GOLD).to_string(), |
There was a problem hiding this comment.
It looks like the size of these headers can vary, and they will not be correctly coloured if they're not exactly the same size as in these strings
There was a problem hiding this comment.
My bad! Maybe a regex would be a better fit here?
aoc-client/src/lib.rs
Outdated
| .replacen("Rank", &"Rank".color(SILVER).to_string(), 2) // "Rank" also in explanation | ||
| .replacen("Score", &"Score".color(SILVER).to_string(), 2); // "Score" also in |
There was a problem hiding this comment.
The words in the header are not being coloured as you printed them before (on lines 465-466). We can probably leave the explanation uncoloured though
There was a problem hiding this comment.
Sorry for being unclear in the comments, it was my intention for the explanation to remain uncolored since that is the behavior displayed on the website.
feat: Colored text for personal stats
…into personal_stats
As suggested in
CONTRIBUTING.md, this feature adds the ability to display a user's personal stats for a given year.While testing, I noticed that if you try to access personal stats while not logged in, the site redirects to show the global stats. I currently have
show_personal_stats()return anAocError::AocResponseErrorin this case, but I wasn't super sure if that correctly describes what's happening. Any suggestions for a different error to return when this happens?